[Nix-dev] i3 to 4.5.1 and Pango fonts

[Pablo Costa]

Hello everybody, and Rok in special!

I want to have antialiased fonts on the i3 window manager.

For some reason, the current nix expression includes a sed command to get
rid of the Pango support.
There is also a funny override for Cairo on the i3lock package, in
pkgs/top-level/all-packages.nix:

i3 = callPackage ../applications/window-managers/i3 { };
i3lock = callPackage ../applications/window-managers/i3/lock.nix { cairo =
cairo.override { xcbSupport = true; }; };
i3status = callPackage ../applications/window-managers/i3/status.nix { };

Is there any reason for the override not to be on
pkgs/applications/window-managers/i3/lock.nix? Having it on
all-packages.nix sounds to me like a temporary workaround.
Would the override make sense also on
pkgs/applications/window-managers/default.nix for i3 wm itself?
Certainly not on the i3status package as it does not render anything, it
just prepares the text for the i3bar.

I added the "pango" dependency and removed the sed command that prevented
it from being used.
I also updated the version number and hash of the wm to the recently
released 4.5.1. Please find the release notes below.

Would you mind having a look at it and giving some feedback or advice?

Thanks!
Pablo

=====8<----------------------------------

~/tmp/nixpkgs$ git diff
diff --git a/pkgs/applications/window-managers/i3/default.nix
b/pkgs/applications/window-managers/i3/default.nix
index f8e4e16..4173660 100644
--- a/pkgs/applications/window-managers/i3/default.nix
+++ b/pkgs/applications/window-managers/i3/default.nix
@@ -1,21 +1,20 @@
 { fetchurl, stdenv, which, pkgconfig, libxcb, xcbutilkeysyms, xcbutil,
   xcbutilwm, libstartup_notification, libX11, pcre, libev, yajl,
-  libXcursor, coreutils, perl }:
+  libXcursor, coreutils, perl, pango }:

 stdenv.mkDerivation rec {
   name = "i3-${version}";
-  version = "4.5";
+  version = "4.5.1";

   src = fetchurl {
     url = "http://i3wm.org/downloads/${name}.tar.bz2";
-    sha256 = "1kiffcbvvjljqchw9ffgy9s8f9z06i8805jvjas58q5i2yxl5kcy";
+    sha256 =
"bae55f1c7c4a21d71aae182e4fab6038ba65ba4be5d1ceff9e269f4f74b823f2";
   };

   buildInputs = [ which pkgconfig libxcb xcbutilkeysyms xcbutil xcbutilwm
-    libstartup_notification libX11 pcre libev yajl libXcursor perl ];
+    libstartup_notification libX11 pcre libev yajl libXcursor perl pango ];

   patchPhase = ''
-    sed -i -e '/^# Pango/,/^$/d' common.mk
     patchShebangs .
   '';

=====8<----------------------------------

Release notes for i3 v4.5.1

This is the i3 v4.5.1, a bugfix release. This version is considered stable.
All users of i3 are strongly encouraged to upgrade.
This release fixes an i3 lockup when dragging floating windows from one
monitor to another.
Furthermore, in the release process for v4.5, there was a human error
leading to i3 thinking that v4.5 is a debug version, therefore allocating
25 MB of shared memory logging ringbuffer by default.

Changes in v4.5.1

  • Bugfix: Don’t warp the pointer when dragging floating windows
  • i3-dmenu-desktop: improve error message when dmenu cannot be found
  • Add YAJL_CFLAGS to i3-msg.mk

-- Michael Stapelberg, 2013-03-18
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.science.uu.nl/pipermail/nix-dev/attachments/20130319/b682e902/attachment.html