[Nix-dev] [PATCH-in-git-commit] Fixed Openssh HPN support

[Bryce L Nordgren]

On Fri, Oct 5, 2012 at 1:39 AM, Lluís Batlle i Rossell <viric at viric.name>wrote:

> On Fri, Oct 05, 2012 at 12:57:40AM +0000, Bryce L Nordgren wrote:
> > I did make a patch against 6.1p1 by manually entering the 3 rejected
> hunks.
> > My limited testing with both 5.9p1 and 6.1p1 quickly led to stalled
> > transfers. If you're interested, I could share that too.
>
> Do you mean that your patch for HPN for 6.1 works fine? I don't clearly
> understand what do you mean by "stalled transfers", and with what version
> you
> get them.
>

My test was to "scp -r" a drupal working directory. It's about 8Mb of tiny
files. It stops halfway thru. I waited a minute or so for it to resume,
then killed the transfer. This occurs with both the 5.9p1/PSC patch and
with 6.1p1/my patch. Unpatched, the transfer completes normally. I did not
test a handful of large files, which is really closer to the use case PSC
was envisioning.

>
> In any case, thank you for revisiting the HPN support! I was looking into
> it
> last week again, but I didn't dare to port the patch to 6.1. And I hadn't
> thought of choosing an older openssh only for hpnSupport.
>

I had mixed feelings about just applying the old patch to the new source,
particularly when one hunk was rejected because the #define value from the
patch was taken by openssh upstream. I changed the value so it didn't
conflict, but I didn't take the time to ensure that nothing else depended
on that value being exactly the same.

Thank you!
>

You're welcome!
Bryce
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.science.uu.nl/pipermail/nix-dev/attachments/20121005/be6c03d3/attachment.html