[Nix-dev] nodejs 5.x failing on darwin

[Tobias Pflug]

I tried it and it builds just fine. Thanks Dan! I created a PR updating the quite outdated 5.1.1 to 5.4.1 - maybe you could have a look at it. 

Was my first PR to nixpks but since I only had to update the version and the sha I hope i could not do much wrong ;)

https://github.com/NixOS/nixpkgs/pull/12506

-Tobi


Sent from my iPhone

> On 20 Jan 2016, at 04:44, Daniel Peebles <pumpkingod at gmail.com> wrote:
> 
> It turns out the patch (and another one) simply wasn't needed anymore with the new version of nodejs :)
> 
> To determine that, I ran the build with `nix-build -K`, such that when it failed, it would leave the files in place (and tell me where it left them). I then checked the file it claimed had failed and eyeballed the patch. After a few glances, it appeared that the patch had already been applied (roughly), which I assume means that someone made the change upstream.
> 
> So I took the patch out of the patch list, tried again, and got another failed patch, this time to configure. Looked again at the failed file, this time found there was no analog for the piece of code being patched, but that the new logic was different enough to perhaps not warrant patching in the same way. I took it out, rebuild, and everything seemed to work fine.
> 
> I also removed a spurious substituteInPlace from the prePatch phase, since the text it was looking for didn't seem to exist anymore (or have anything similar in the new file).
> 
> The result of all that is https://github.com/NixOS/nixpkgs/commit/5cb1e43fd6eb7f87c9b17e9dc6d1a92ae7c360a4.
> 
> I just got a notification from Travis that it had failed, but I believe that's due to the broken Nix 1.11 release and not anything about my change. If you want to test, please let me know if things work for you, and if not reopen the ticket.
> 
> -Dan
> 
>> On Mon, Jan 18, 2016 at 5:16 PM, Tobias Pflug <tobias.pflug at gmx.net> wrote:
>> Hey Dan,
>> 
>> i would be willing to help. I might just need a little intro to get the hang of it. I would in fact be very interested in ensuring that recent nodejs versions are available and buildable on both, darwin and linux - and I have both available to me as well.
>> 
>> So Maybe we can get in contact about this. Until then, thanks for your swift response.
>> 
>> br,
>> Tobi
>> 
>> Sent from my iPhone
>> 
>>> On 18 Jan 2016, at 22:51, Daniel Peebles <pumpkingod at gmail.com> wrote:
>>> 
>>> I think Jude Taylor (@pikajude) and I have historically been the main "darwin fixer-uppers", but it's a bit tiring when everything's shifting under us all the time.
>>> 
>>> Anyway, I'll try to take a look at how to fix the patch later tonight, but in the longer run the bottleneck on the two of us isn't sustainable, and we need more "holistic nix-on-darwin" maintainers to help us out in a cross-cutting manner. At least until we figure out a way to give Linux users a local/lightweight "did I break Darwin" smoke test :)
>>> 
>>> -Dan
>>> 
>>> 
>>>> On Mon, Jan 18, 2016 at 4:36 PM, Tobias Pflug <tobias.pflug at gmx.net> wrote:
>>>> Hi,
>>>> 
>>>> nodejs 5.x has been failing to build on OSX for a while now.
>>>> 
>>>> The no-xcode patch cannot be applied anymore. I created an issue [1] but so far there has been very little interest/feedback. I am currently evaluating to move parts of our production setup to nix and this a pretty big problem for me. 
>>>> 
>>>> I have been trying to reach out to people on irc as well but so far without any success.
>>>> 
>>>> Is anyone here able to help me out on this? I tried to have a go at fixing the patch myself but got lost rather quickly.
>>>> 
>>>> Best tegards,
>>>> Tobi
>>>> 
>>>> [1]: https://github.com/NixOS/nixpkgs/issues/12305
>>>> 
>>>> Sent from my iPhone
>>>> 
>>>> _______________________________________________
>>>> nix-dev mailing list
>>>> nix-dev at lists.science.uu.nl
>>>> http://lists.science.uu.nl/mailman/listinfo/nix-dev
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.science.uu.nl/pipermail/nix-dev/attachments/20160120/8f7fa4ef/attachment.html