[Nix-dev] Proposed package for x2goclient

[Bjørn Forsman]

On 9 February 2015 at 22:13, Christoph-Simon Senjak
<christoph.senjak at googlemail.com> wrote:
> Hello.
>
> I am new to NixOS, and I am currently trying to build a package for the
> x2goclient.

Cool! Somewhere on my TODO list is writing an x2go service module :-)

> I brought it to a state where I can use it, but it would be
> nice if you could give me some comments about them.
>
> https://github.com/dasuxullebt/nixpkgs/blob/master/pkgs/applications/networking/remote/x2goclient/default.nix
>
> https://github.com/dasuxullebt/nixpkgs/blob/master/pkgs/tools/admin/nxproxy/default.nix
>
> https://github.com/dasuxullebt/nixpkgs/blob/master/pkgs/development/libraries/libxcomp/default.nix

Since you already have a fork, why not make a pull request? Then we
can comment / merge easily.

After a quick look, I'd like to comment:

* Indenting: use 2 spaces per level (and never hard-tab)
* One package had
    name = "foo";
    version "1.2";
  There is nothing "magical" about the version attribute, so for nix
tools (especially nix-env) to "see" the version number you should have
name = "foo-${version}". (Nix splits package names in name + version
at the first dash with a number following it.)

Best regards,
Bjørn Forsman