[Nix-dev] Making stdenv/setup.sh more verbose

Yury G. Kudryashov urkud.urkud at gmail.com
Fri Jan 20 15:00:36 CET 2012


Eelco Dolstra wrote:

> Hi,
> 
> On 20/01/12 07:01, Michael Raskin wrote:
> 
>>> Review the attached patch, please.
>> 
>> Looks like a strict improvement..
> 
> I disagree.  What useful information do most of these communicate?  E.g.
> if a
> mkdir succeeds, why do I have to be informed about it?  It's only
> interesting if it fails.
> 
> Rob actually just suggested to make the unpackPhase less verbose, i.e.
> drop the
> "-v" flag in "tar" and "cp".  But maybe that should be optional.
I prefer to see what happens during the build even if everything succeeds. 
E.g., I don't like if a build script creates a directory behind the scenes 
(i.e., without any output).
> 
>>> +    mkdir -pv $out/bin
>>> +    cp -v "$@" $out/bin
> 
> This actually made me wonder why we have an "installBin" function in
> stdenv.  It doesn't appear to be used anywhere in Nixpkgs...
Then we can remove this function.
-- 
Yury G. Kudryashov,
mailto: urkud at mccme.ru



More information about the nix-dev mailing list