[Nix-dev] Re: [Nix-commits] SVN commit: nix - r28912 - in nixpkgs/trunk/pkgs: applications/misc/get_iplayer top-level

[Rob Vermaas]

Hi Ludo,

>> +  name = "get_iplayer-2.80";
>
> I think the convention is to use hyphens, even if the upstream package
> uses a different convention.

We have no such convention for the name attribute as fas as i know.

> Can you explicitly add meta.license = "unfree"?

I was lazy (actually, am always). Will add it this afternoon.

> Likewise, could you add a meta.description and meta.homepage because the
> name is not very descriptive.  ;-)

The name is very descriptive if you know what BBC iPlayer is ;-)

-- 
Rob Vermaas

[email] rob.vermaas at gmail.com