[Nix-dev] Re: [Nix-commits] SVN commit: nix - r28912 - in nixpkgs/trunk/pkgs: applications/misc/get_iplayer top-level

[Ludovic Courtès]

Hi Rob!

Rob Vermaas <rob.vermaas at gmail.com> skribis:

> Author: rob
> Date: Tue Aug 30 00:14:16 2011
> New Revision: 28912
> URL: https://svn.nixos.org/websvn/nix/?rev=28912&sc=1
>
> Log:
> add get_iplayer 2.80

[...]

> +{stdenv, fetchurl, flvstreamer, ffmpeg, makeWrapper, perl}:
> +
> +stdenv.mkDerivation {
> +  name = "get_iplayer-2.80";

I think the convention is to use hyphens, even if the upstream package
uses a different convention.

> +  installPhase = '' 
> +    ensureDir $out/bin
> +    cp get_iplayer $out/bin
> +    wrapProgram $out/bin/get_iplayer --suffix PATH ${ffmpeg}/bin:${flvstreamer}/bin
> +  '';  

Can you explicitly add meta.license = "unfree"?

Likewise, could you add a meta.description and meta.homepage because the
name is not very descriptive.  ;-)

Thanks,
Ludo’.