[Nix-dev] my patchset in a real diff format

[Ilya Cassina]

On Wednesday 13 October 2010 20:52:30 you wrote:
> >  haskell-Graphalyze_and_deps : add Graphalyze haskell package (as well 
as
> > its deps: bktrees, colour, graphviz)
> 
> I have only looked at this one. Thanks for the contribution. Could I
> ask you to edit your patch slightly?
> 
> The descriptions are too long. I usually use just the one-sentence
> synopsis from the Cabal file. If you want longer descriptions, use
> longDescription instead.
> 
> It would be nice if you could include a license field as well. Not all
> old Haskell packages have one, but I try to include it at least for
> all packages I add or modify.
> 
> Finally, the relatively recent use of callPackage makes the use of
> "inherit" more or less superfluous. So you should be able to omit the
> "inherit" lines for Graphalyze and graphviz and just keep the fgl =
> fgl_5_4_2_3 line.
> 
> If you resend the edited patch, I'll apply it.

Here they are! (*packages*.diff for top-level/haskell-packages.nix)


Ilya
-------------- next part --------------
A non-text attachment was scrubbed...
Name: haskell_patchset-1.1.diff
Type: text/x-patch
Size: 2286 bytes
Desc: not available
Url : http://lists.science.uu.nl/pipermail/nix-dev/attachments/20101013/658d30db/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: haskell_packages_patchset-1.1.diff
Type: text/x-patch
Size: 1250 bytes
Desc: not available
Url : http://lists.science.uu.nl/pipermail/nix-dev/attachments/20101013/658d30db/attachment-0001.bin