[Nix-dev] Re: Pidgin plugins.

[Ludovic Courtès]

Hello,

Some nitpicking:

David Brown <nix at davidb.org> writes:

> +++ b/pkgs/applications/networking/instant-messengers/pidgin-plugins/sipe/default.nix
> @@ -0,0 +1,21 @@
> +args: with args;

This idiom should not be used, as per ‘doc/coding-conventions.xml’.

> +  meta = {
> +    description = "SIPE plugin for Pidgin IM.";
> +    homepage = http://sipe.sourceforge.net/;
> +  };

The ‘description’ field should not be a sentence, and thus should not
end with a period.

Also it’d be great if you could provide the other meta attributes (see
‘doc/meta.xml’).  :-)

Thanks,
Ludo’.