[Nix-dev] Re: Python refactoring again (second attempt)

Ludovic Courtès ludo at gnu.org
Mon May 10 11:50:27 CEST 2010


Hi,

Marc Weber <marco-oweber at gmx.de> writes:

> Continuation of thread:
>   Subject: Re: [Nix-dev] gitorious mirror -Python refactoring again (second attempt)
>   Date: Sun, 09 May 2010 23:28:28 +0200
>   Message-Id: <1273440254-sup-8101 at nixos>

Would have been more convenient if you had actually replied to the
thread.

>> The definition of ‘buildPython26Package’ looks somewhat circular to me.
>> Am I missing something?
> No. You're right. I forgot to drop passing this argument.

Ahem, then please please test before committing anything.

>> Please keep only one ‘python’ argument.  This function can be called
>> with ‘python = pythonFull’ if need be; there’s no need to add a new
>> argument.
>
> How would this look like?
>
> python26PackagesFull = pythonPackagesBuilderFun pythonFull;
> python26Packages = pythonPackagesBuilderFun python;

Perhaps I wasn’t clear: I was suggesting that the function defined in
python-packages.nix should take only one ‘python’ argument.

Thanks,
Ludo’.




More information about the nix-dev mailing list