[Nix-dev] Re: [Nix-commits] SVN commit: nix - 17405 - MarcWeber - in nixpkgs/trunk/pkgs: tools/package-management/nix top-level

[Eelco Dolstra]

Hi,

Ludovic Courtès wrote:

>> +  allPatches =
>> +      patches ++ lib.optional debugcCoercionFailuresPatch
>> +                      (fetchurl { url = http://mawercer.de/~marc/debug-coercion-failures.patch; sha256 = "13q6vbxp3p36hqzlfp0hw84n6f1hzljnxqy73vr2bmglp8np24wy"; });
>>    
>> +  vName = "nix-0.13pre17232";
>> +  name = "${vName}${nameSuffix}${if allPatches == [] then "" else "-patched"}";
> 
> IMO Nixpkgs trunk is really *not* the place for such experiments.

Seconded.  It's also likely to break every time the upstream package is updated,
and adds a substantial amount of clutter to the expression just to support a
single patch.

> I suggest that you keep such patches local to your Nixpkgs development
> tree

Site-local patches can also be kept conveniently using packageOverrides in
~/nixpkgs/config.nix.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/