[Nix-dev] Re: [Nix-commits] SVN commit: nix - 13932 - eelco - nixos/trunk/boot

[Ludovic Courtès]

Hi,

Eelco Dolstra <e.dolstra at tudelft.nl> writes:

> Author: eelco
> Date: 2009-02-01 19:53:59 +0000 (Sun, 01 Feb 2009)
> New Revision: 13932
>
> You can view the changes in this commit at:
>    https://svn.nixos.org/viewvc/nix?rev=13932&view=rev
>
> Modified:
>    nixos/trunk/boot/boot-stage-1-init.sh

[...]

> +    # For unclean ext3 file systems, fsck.ext3 should just replay the
> +    # journal and exit, but in practice this takes *much* longer than
> +    # letting the kernel recover the FS.  So, don't run fsck on
> +    # journalling file systems.
> +    eval $(fstype "$device")
> +    if test "$FSTYPE" = ext3 -o "$FSTYPE" = ext4 -o "$FSTYPE" = reiserfs -o "$FSTYPE" = xfs -o "$FSTYPE" = jfs; then
> +        return 0;
> +    fi

Just because recovery can be performed pretty fast doesn't mean `fsck'
should *never* be run.  It's still recommended, AFAIUI, to run it from
time to time.  My understanding of your patch is that it will just never
be run, leaving no chance to detect (and repair) inconsistencies that
could otherwise go undetected for long periods of time.

Thanks,
Ludo'.