[Nix-dev] Re: firefox-3.0.1-with-plugins fails to build

[Eelco Dolstra]

Hi,

Ludovic Courtès wrote:

>> ===================================================================
>> --- pkgs/top-level/all-packages.nix	(revision 13165)
>> +++ pkgs/top-level/all-packages.nix	(working copy)
>> @@ -7304,21 +7304,11 @@
>>      inherit fetchurl stdenv lzma pkgconfig perl zip libjpeg libpng zlib cairo
>>        python dbus dbus_glib freetype fontconfig bzip2 xlibs;
>>      inherit (gnome) libIDL libgnomeui gnomevfs gtk pango;
>> +    xulrunner = xulrunner3;
>>    });
> 
> Why not use `icecatXulrunner3' here instead of Mozilla's version?  Looks
> to me that it would be more reliable, especially if IceCat contains
> changes to libxul, as you noted.

It would save a lot of disk space / build time if you want to have both
Mozilla's and GNU's packages installed (e.g. GNU IceCat and Mozilla's
Thunderbird 3).  OTOH, we could also turn it around and use the IceCat xulrunner
to build Firefox :-)

>> -  patches = [ ./skip-gre-registration.patch ];
>> +  #patches = [ ./skip-gre-registration.patch ];
> 
> Is that necessary?

Disabling it didn't seem to have an adverse effect, but I don't really know what
it does :-)

>> +    # From the original .mozconfig (which we delete below because it interferes with our settings):
>> +    "--with-user-appdir=.gnuzilla"
>> +    "--with-distribution-id=org.gnu.gnuzilla"
> 
> Why do we need these?
> 
>> +    "--with-branding=browser/branding/unofficial"
> 
> This one shouldn't be needed with IceCat, I suppose.

These where all flags from the .mozconfig in IceCat.  Actually, the
--with-user-appdir has a rather big effect (it causes profiles to be stored
under ~/.gnuzilla instead of ~/.mozilla).  I guess the distribution ID doesn't
matter.

> MPlayer-Plugin expects `xpidl' in its PATH so I think this shouldn't be
> removed.

The idea is that xpidl now comes from the xulrunner package (which is a
propagatedBuildInputs, so MPlayer-Plugin will find it automatically).

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/