[Nix-dev] Re: [Nix-commits] SVN commit: nix - 12037 - eelco - in nixpkgs/trunk/pkgs: applications/version-management/git top-level

[Ludovic Courtès]

Hi,

I was just hit by the aftermath of this patch...  ;-)

Eelco Dolstra <e.dolstra at tudelft.nl> writes:

> Author: eelco
> Date: 2008-06-11 12:31:44 +0000 (Wed, 11 Jun 2008)
> New Revision: 12037
>
> You can view the changes in this commit at:
>    https://svn.nixos.org/viewvc/nix?rev=12037&view=rev
>
> Modified:
>    nixpkgs/trunk/pkgs/applications/version-management/git/default.nix
>    nixpkgs/trunk/pkgs/top-level/all-packages.nix
>
> Log:
> * git: make the TCL/TK GUI optional (git.guiSupport).

I find it questionable, see:

  $ du -ms /nix/store/0w7prlh0c8dj3dc9c9gp7fyz9a2bq027-tcl-8.4.18/
  6       /nix/store/0w7prlh0c8dj3dc9c9gp7fyz9a2bq027-tcl-8.4.18/
  $ du -ms /nix/store/g8gwivkljnk6cq0ivjhpza4ad0hvmhja-tk-8.4.16/
  5       /nix/store/g8gwivkljnk6cq0ivjhpza4ad0hvmhja-tk-8.4.16/

Above all, the diagnostic looks bad:

  $ gitk 
  /nix/var/nix/profiles/per-user/ludo/profile/bin/gitk: line 3: exec: wish: not found

Can we either remove the option altogether (my preference), or make sure
Tcl/Tk programs don't get installed when the option is disabled?

> * git: always install the Emacs mode but don't depend on Emacs to do
>   it (just don't build the .elc files).

I think we discussed it on IRC: it's a build-time dependency, so who
cares?

Thanks,
Ludovic.