[Nix-dev] Re: [Nix-commits] SVN commit: nix - 12509 - MarcWeber - in nixpkgs/trunk/pkgs: development/misc/bleeding-edge-repos misc/bleeding-edge-fetch-info misc/ghc68extraLibs top-level

[Eelco Dolstra]

Hi Marc,

Marc Weber wrote:

Some comments:

> Added:
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/happs_hsp.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/happs_hsp_template.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/haskell_src_exts.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/hjavascript.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/hjquery.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/hjscript.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/hsp.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/hspCgi.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/hsp_xml.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/libnih.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/plugins.nix
>    nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/upstart.nix
>    nixpkgs/trunk/pkgs/misc/ghc68extraLibs/hsp-darcs-patch
>    nixpkgs/trunk/pkgs/misc/ghc68extraLibs/hsx-patch
>    nixpkgs/trunk/pkgs/misc/ghc68extraLibs/plugins-darcs-patches

Please give patches a ".patch" extension.

> Added: nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/happs_hsp.nix
> ===================================================================
> --- nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/happs_hsp.nix	                        (rev 0)
> +++ nixpkgs/trunk/pkgs/misc/bleeding-edge-fetch-info/happs_hsp.nix	2008-08-06 11:41:17 UTC (rev 12509)
> @@ -0,0 +1,3 @@
> + args: with args; fetchurl { 
> +  url = http://mawercer.de/~nix/repos/happs_hsp.tar.gz;
> +  sha256 = "cc4df8509468ec83e3f448bb1e1fe5cb7e1f2408851861df31f139778e3c8cc8";}

There are a lot of these tiny files which only contain a fetchurl call.  Maybe 
it's better to have them in one file?

> Modified: nixpkgs/trunk/pkgs/misc/ghc68extraLibs/default.nix
> ===================================================================
> --- nixpkgs/trunk/pkgs/misc/ghc68extraLibs/default.nix	2008-08-06 09:50:41 UTC (rev 12508)
> +++ nixpkgs/trunk/pkgs/misc/ghc68extraLibs/default.nix	2008-08-06 11:41:17 UTC (rev 12509)
> @@ -52,6 +52,16 @@
>  
>  */
>  
> +          # plugins doesn't compile with recent cabal
> +          # plugins = { name="plugins-1.2"; src = fetchurl { url = http://hackage.haskell.org/packages/archive/plugins/1.2/plugins-1.2.tar.gz; sha256 = "1v2b3p3d2d3ab8zlzad4i6yy3zmarvkd09r71yc237xx66s7i9s5"; }; p_deps = [ x.array x.base x.cabal_darcs x.containers x.directory x.ghc x.haskellSrc x.process x.random ]; };
> +          plugins_darcs = { name="plugins-darcs"; src = sourceByName "plugins"; p_deps = [ x.array x.base x.cabal_darcs x.containers x.directory x.ghc x.haskellSrc x.process x.random ]; 

Could you clean up the indentation of this file?  It has several lines that are 
hundreds of characters long, which is too much even on a big monitor ;-)  Also, 
the lack of empty lines between definitions makes this file *very* hard to read. 
  The indentation depth is also inconsistent, some parts make huge indentation 
jumps, like in

           postgresql_bindings = rec { name = "PostgreSQL-0.2"; p_deps = [x.base 
x.mtl postgresql x.haskell98];
                           src = fetchurl { url = 
http://hackage.haskell.org/packages/archive/PostgreSQL/0.2/PostgreSQL-0.2.tar.gz";

which would be better written as

   postgresql_bindings = rec {
     name = "PostgreSQL-0.2";
     p_deps = [
       x.base x.mtl postgresql x.haskell98
     ];
     src = fetchurl {
       url = "http://hackage.haskell.org/...";
       ...

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/