[Nix-dev] Reengineered npm2nix: call for feedback

[Sander van der Burg]

Ah well spotted!

Just implemented a fix for this and it should work now.


On Mon, Oct 6, 2014 at 9:59 PM, Paul Colomiets <paul at colomiets.name> wrote:

> Hi,
>
> On Wed, Oct 1, 2014 at 11:40 AM, Sander van der Burg
> <svanderburg at gmail.com> wrote:
> > I haven't implemented any checks so far, but that could be improved. The
> > version number that you specified is actually not a valid semver version
> > specification. A version number should consist of 3 components. Also, I
> > could check for semver validity as well.
>
> Ah, thanks. Didn't know anybody is limiting number of components in
> version number.
>
> Still https://github.com/NixOS/npm2nix/issues/8 and
> https://github.com/NixOS/npm2nix/issues/9 (which I believe are the
> same thing), failing in your implementation too.
>
>
> --
> Paul
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.science.uu.nl/pipermail/nix-dev/attachments/20141006/b6ed65f6/attachment.html