[Nix-dev] RFC: three dying pull requests (let's keep them alive)

John Wiegley johnw at newartisans.com
Wed Aug 27 19:32:26 CEST 2014


>>>>> Daniel Peebles <pumpkingod at gmail.com> writes:

> I've noticed a bit of a pattern recently on the nix github and wanted to try
> to stop it before Shea Levy decided this sort of work wasn't worth his time
> anymore. I'm not proposing that we insta-merge all his changes, but can
> anyone interested at least chime in with feedback so that these pull
> requests don't die on the vine?

I heartily agree.

Shae, would you be willing to create an experimental-shlevy branch that
contains these three changes merged against current master?  Then perhaps
Joel, Daniel and I can switch to using it for couple weeks, and if everything
looks good and remains working, we simply merge it to master.

Sadly, I'm not qualified yet to judge the merits of these changes -- although
they sound like something I might want in future -- so I say we bring them in
solely based on all the work you've done, and because you think they will
improve Nix as a platform.  I'm willing to trust your judgment in lieu of
having time to work through them in detail.

That is, of course, unless Eelco or others think they lack technical merit.

John


More information about the nix-dev mailing list