[Nix-dev] Samba, nixpkgs and GNU/Hurd

[Bjørn Forsman]

On 17 August 2013 15:07, Ludovic Courtès <ludo at gnu.org> wrote:
> Hi!
>
> Sorry for the late reply.

It's ok :-)

> Bjørn Forsman <bjorn.forsman at gmail.com> skribis:
>
>> I want to update samba from 3.6.8 to 3.6.18 (latest 3.x version),
>> but then the GNU/Hurd patch that you have added failed. Is it OK if I
>> drop the patch? Or do you want to bump samba yourself and re-create
>> the patch?
>
> Could you try to port the patch, if it’s not too hard?

I tried to update it, but it changes one of several very similar
looking blocks of code. Without a way to verify my change I don't feel
like committing it.

> If it’s too difficult, just comment it out and leave it in the repo for
> future reference.

I'd prefer to remove the patch instead of leaving it dangling in
nixpkgs. You can always bring it back with git. Or with the mailing
list archive (see below). Ok?

`libnss_wins' uses pthreads but is built without `-pthread'.  This is
not a problem when building natively on GNU/Linux, but causes troubles
when cross-building for GNU/Hurd (undefined references to libpthread
functions.)

--- samba-3.6.1/source3/Makefile.in 2012-02-22 15:25:15.000000000 +0100
+++ samba-3.6.1/source3/Makefile.in 2012-02-22 15:25:47.000000000 +0100
@@ -2760,6 +2760,7 @@ bin/vlp at EXEEXT@: $(BINARY_PREREQS) $(VLP
  @echo "Linking $@"
  @$(SHLD) $(LDSHFLAGS) -o $@ $(WINBIND_WINS_NSS_OBJ) \
  $(LDAP_LIBS) $(KRB5LIBS) $(LIBS) $(LIBTALLOC_LIBS) $(LIBTDB_LIBS)
$(ZLIB_LIBS) \
+ $(PTHREAD_LDFLAGS) \
  @SONAMEFLAG@`basename $@`@NSSSONAMEVERSIONSUFFIX@

 bin/winbind_krb5_locator. at SHLIBEXT@: $(BINARY_PREREQS)
$(WINBIND_KRB5_LOCATOR_OBJ) $(LIBWBCLIENT)

Best regards,
Bjørn Forsman