[Nix-dev] [Nix-commits] [NixOS/nixpkgs] 3afa95: Added androidenv - the Android SDK, their addition...

[Eelco Dolstra]

Hi,

On 07/11/12 21:10, Sander van der Burg wrote:

>   Added androidenv - the Android SDK, their additions and two functions that build and emulate Android Apps

Cool!

One remark: it's not appropriate to keep the source code of packages in the
Nixpkgs source tree, so pkgs/development/androidenv/examples/src/myfirstapp
should be moved into an external source tarball (or use fetchgit, or whatever).
 (Also, who wrote it? Comment suggests it's from the Android docs...)

Also, where do "addon.xml" and "repository-7.xml" come from, and why should they
be kept in-tree?

-- 
Eelco Dolstra | LogicBlox, Inc. | http://nixos.org/~eelco/