[Nix-dev] nix-prefetch-git in nixpkgs

[Nicolas Pierron]

On Fri, Jun 8, 2012 at 3:13 AM, Kirill Elagin <kirelagin at gmail.com> wrote:
> 2012/6/8 Nicolas Pierron <nicolas.b.pierron at gmail.com>
>>
>> Hi,
>>
>> On Thu, Jun 7, 2012 at 7:06 AM, Kirill Elagin <kirelagin at gmail.com> wrote:
>> > I'm reading nix-prefetch-git from HEAD right now and its behaviour seems
>> > to
>> > be consistent with documentation except for a small bug that renders
>> > those
>> > --* setters a bit unusable (see this).
>>
>> I don't understand, the for loop should still iterate over the
>> arguments, unless bash is removing them from the list of argument
>> because they are directly used.
>
> I probably should explain what was going on.
> Note that when you call `./nix-prefetch-git --url
> git://gitorious.org/qt-labs/jom.git --rev HEAD`,
> $3 is "--rev", and due to those lines that I modified in the first patch,
> $expHash becomes "--rev".
> Since there is no `--hash` option, $expHash is not overwritten later and
> that's why call to nix-store fails.

Good catch.

-- 
Nicolas Pierron
http://www.linkedin.com/in/nicolasbpierron - http://nbp.name/