[Nix-dev] nix-prefetch-git in nixpkgs

[Kirill Elagin]

Hi,

I'm reading nix-prefetch-git from HEAD right now and its behaviour seems to
be consistent with documentation except for a small bug that renders those
--* setters a bit unusable (see
this<https://github.com/kirelagin/nixpkgs/commit/7d786f3b7b41d1a417cde496cc002e5fa6f2352e>
).

Next. You are giving a *tag* as `rev`. `rev` must be one of "HEAD",
`refs/*`-reference or commit hash (actually adding support for tags would
be really nice). The problem is that the script doesn't have a code path
that handles invalid rev's — it just doesn't do anything (see
here<https://github.com/kirelagin/nixpkgs/commit/61a640d13ca0a1beeba738989716bfa5fb0ee92f>
) =).

--
Кирилл Елагин


2012/6/4 Lluís Batlle i Rossell <viric at viric.name>

> Hello,
>
> I can't understand how nix-prefetch-git works.
> If I call:
>  ./nix-prefetch-git git://gitorious.org/qt-labs/jom.git v1.0.11
> it does not fetch anything and gives always the same hash.
>
> If I call:
>  ./nix-prefetch-git --url git://gitorious.org/qt-labs/jom.git --rev
> v1.0.11
> it says: unknown flag '--rev'.
>
> And its output without parameters is a help that says:
>  syntax: nix-prefetch-git [options] [URL [REVISION [EXPECTED-HASH]]]
>
>  Options:
>      --out path      Path where the output would be stored.
>      --url url       Any url understand by 'git clone'.
>      --rev ref       Any sha1 or references (such as refs/heads/master)
>      --hash h        Expected hash.
>      --deepClone     Clone submodules recursively.
>      --no-deepClone  Do not clone submodules.
>      --leave-dotGit  Keep the .git directories.
>      --builder       Clone as fetchgit does, but url, rev, and out option
> are mandatory.
>
> So, do I fail to understand how to call nix-prefetch-git, or it is very
> wrong? :)
>
> Thank you,
> Lluís.
> _______________________________________________
> nix-dev mailing list
> nix-dev at lists.science.uu.nl
> http://lists.science.uu.nl/mailman/listinfo/nix-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.science.uu.nl/pipermail/nix-dev/attachments/20120607/3d395fad/attachment.html