[Nix-dev] Minecraft patch

Carles Pagès page.lists at gmail.com
Fri Jan 20 15:05:41 CET 2012


Here is the patch with the suggested changes. There is no url to a specific
version since this is only the downloader/launcher (I added a comment about
this), so I also removed the version from the name.

Thanks

2012/1/19 Yury G. Kudryashov <urkud.urkud at gmail.com>

> Carles Pagès wrote:
>
> > Hi,
> >
> > Here's a patch to add an expression for Minecraft. Review/commit are
> > welcome.
> 1. Is there any URL to a particular version?
> 2. ensureDir is deprecated in favour of `mkdir -pv`.
> 3. Why do you need patchPhase?
> 4. No need to copy tarball twice.
> 5. Make build script more verbose (cp -v etc.), please.
> 6. Mention yourself in meta.maintainers.
> --
> Yury G. Kudryashov,
> mailto: urkud at mccme.ru
>
> _______________________________________________
> nix-dev mailing list
> nix-dev at lists.science.uu.nl
> http://lists.science.uu.nl/mailman/listinfo/nix-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.science.uu.nl/pipermail/nix-dev/attachments/20120120/90bdb9f9/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: minecraft.patch
Type: application/octet-stream
Size: 1770 bytes
Desc: not available
Url : http://lists.science.uu.nl/pipermail/nix-dev/attachments/20120120/90bdb9f9/attachment.obj 


More information about the nix-dev mailing list