[Nix-dev] [PATCH] Root filesystem on NFS

[Rickard Nilsson]

Den 2011-10-10 19:56:46 skrev Nicolas Pierron  
<nicolas.b.pierron at gmail.com>:

> Hi Rickard,
>
>> diff --git a/modules/system/boot/stage-1.nix  
>> b/modules/system/boot/stage-1.nix
>> index 8936a11..a7e2c77 100644
>> --- a/modules/system/boot/stage-1.nix
>> +++ b/modules/system/boot/stage-1.nix
>> @@ -169,6 +169,11 @@ let
>>          cp  
>> ${kernelPackages.splashutils}/${kernelPackages.splashutils.helperName}  
>> $out/bin/splash_helper
>>        ''}
>>
>> +      # Copy nfsmount if there any NFS mounts required for boot.
>
> if there *is* any ?

Yes, of course.

>> +      ${optionalString (fileSystems != [] && filter (fs: fs.fsType ==  
>> "nfs" && (fs.mountPoint == "/" || fs.neededForBoot)) fileSystems != [])  
>> ''
>
> the first test is unnecessary.  filter can be applied on an empty list.

OK, I don't really know why I had that first test. It should be removed.

>> +        cp -v ${pkgs.klibc}/lib/klibc/bin.static/nfsmount $out/bin
>> +      ''}
>> +
>>        ${config.boot.initrd.extraUtilsCommands}
>>
>>        # Run patchelf to make the programs refer to the copied  
>> libraries.
>
> The patch seems fine to me.
> Do you mind If I apply the listed modification and if I commit it in
> your behalf ?

No, please do so. Thanks!


   / Rickard