[Nix-dev] [Nix-commits] SVN commit: nix - r30325 - nixos/trunk/modules/installer/tools

[Eelco Dolstra]

On 11/08/2011 01:45 PM, Eelco Dolstra wrote:

> On 11/08/2011 01:05 PM, Nicolas Pierron wrote:
> 
>> The goal of this was to simplify the task for new comers, and avoid
>> them the pain of selecting what they need.  
> 
> I agree with that goal, but it's completely wrong for nixos-hardware-scan to do
> that.  The only thing that that script should do is generate a module that
> enables support for the user's hardware, can be included from configuration.nix,
> and can be re-generated if desired after a hardware change.  It shouldn't enable
> any packages other than required to use the detected hardware (e.g. firmware
> packages).  It's very counter-intuitive for nixos-hardware-scan to install (say)
> Subversion or KDE, depending on what installation CD I happened to use.
> 
> What you want is a installation tool that generates an initial
> configuration.nix.  But that's a separate issue.

P.S. in the absence of such a tool, the manual should just tell users to include

  require = [ "${modulePath}/profiles/graphical.nix" ];

or something similar in their configuration.nix.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/