[Nix-dev] [Nix-commits] SVN commit: nix - r30802 - nixos/trunk/modules/system/boot

[Nicolas Pierron]

Hi,

We should avoid use of config.* for the default attribute.
In such case, you should prefer mkDefault.

Option declaration should not depend on the configuration.
Failing to do so, would likely increase the time used to generate NixOS manual.

On Thu, Dec 8, 2011 at 13:25, Eelco Dolstra <e.dolstra at tudelft.nl> wrote:
> Modified: nixos/trunk/modules/system/boot/kernel.nix
> ==============================================================================
> --- nixos/trunk/modules/system/boot/kernel.nix  Thu Dec  8 10:46:56 2011        (r30801)
> +++ nixos/trunk/modules/system/boot/kernel.nix  Thu Dec  8 12:25:33 2011        (r30802)
> @@ -46,7 +46,7 @@
>     };
>
>     boot.vesa = mkOption {
> -      default = true;
> +      default = config.boot.kernelPackages.splashutils != null;
>       example = false;
>       description = ''
>         Whether to activate VESA video mode on boot.

-- 
Nicolas Pierron
http://www.linkedin.com/in/nicolasbpierron - http://nbp.name/