[Nix-dev] Re: [PATCH] Add Nix expression for Racket.

[Karn Kallio]

Hello, apologies for taking so long to reply.

Attached is a patch which tidies up the Nix expression based on your comments.

> Hi,
> 
> Karn Kallio <tierpluspluslists at gmail.com> writes:
> > This patch adds a Nix expression for Racket to Nixpkgs.
> 
> Thanks!  I just committed it, after removing tabs.

Doh!  I must pay more attention to tab formatting!

> 
> A few comments:
> > --- /dev/null
> > +++ b/pkgs/development/interpreters/racket/default.nix
> > @@ -0,0 +1,70 @@
> > +{ stdenv
> > +, fetchurl
> > +, cairo
> > +, coreutils
> > +, file
> > +, libjpeg
> > +, libpng
> > +, libtool
> > +, libXaw
> > +, libXext
> > +, libXft
> > +, libXrender
> > +, libXt
> > +, libXmu
> > +, mesa
> > +, pkgconfig
> 
> > +, which } :
> This should fit on 3 lines.  :-)
> 

Ok, function arguments now on 3 lines.

> > +  buildInputs = [ cairo
> > +                  coreutils
> 
> What is Coreutils needed?  On GNU systems it’s part of ‘stdenv’, so it’s
> not necessary to explicitly add them.
> 

Ah, thank you.  I included it without realizing at the time it was going to be 
available in the stdenv.

> > +    license = "LGPL";
> 
> You should use, e.g., “LGPLv2+” if it’s “version 2 or later”.
> 

The license is now set to use the lgpl from the stdenv licenses list.  After 
reading over the Racket page and license I think it is just under LGPL2, not 
2+ 

> > +    platforms = [ "i686-linux" "x86_64-linux" ];
> 
> Why not ‘stdenv.lib.platforms.linux’ or some such?
>

Fixed, now takes "linux" from the stdenv platforms list.
 
> Last but not least: you may want to add a ‘maintainers’ field with
> yourself.  :-)

I added myself to the stdenv maintainers list and to the Nix expression as a 
maintainer.

> 
> Thanks,
> Ludo’.

I would like to thank you very much for making these comments.  I find it very 
helpful.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Tidy-up-Nix-expression-for-Racket.patch
Type: text/x-patch
Size: 2242 bytes
Desc: not available
Url : http://lists.science.uu.nl/pipermail/nix-dev/attachments/20100926/0f58bfae/attachment.bin