[Nix-dev] Re: [PATCH] Add Nix expression for Racket.

[Ludovic Courtès]

Hi,

Karn Kallio <tierpluspluslists at gmail.com> writes:

> This patch adds a Nix expression for Racket to Nixpkgs.

Thanks!  I just committed it, after removing tabs.

A few comments:

> --- /dev/null
> +++ b/pkgs/development/interpreters/racket/default.nix
> @@ -0,0 +1,70 @@
> +{ stdenv
> +, fetchurl
> +, cairo
> +, coreutils
> +, file
> +, libjpeg
> +, libpng
> +, libtool
> +, libXaw
> +, libXext
> +, libXft
> +, libXrender
> +, libXt
> +, libXmu
> +, mesa
> +, pkgconfig
> +, which } :

This should fit on 3 lines.  :-)

> +  buildInputs = [ cairo
> +                  coreutils

What is Coreutils needed?  On GNU systems it’s part of ‘stdenv’, so it’s
not necessary to explicitly add them.

> +    license = "LGPL";

You should use, e.g., “LGPLv2+” if it’s “version 2 or later”.

> +    platforms = [ "i686-linux" "x86_64-linux" ];

Why not ‘stdenv.lib.platforms.linux’ or some such?

Last but not least: you may want to add a ‘maintainers’ field with
yourself.  :-)

Thanks,
Ludo’.