[Nix-dev] Re: [Nix-commits] SVN commit: nix - r24477 - in nixos/trunk/modules: . system/boot

[Evgeny Egorochkin]

On Tuesday 26 October 2010 09:32:17 Nicolas Pierron wrote:
> On Tue, Oct 26, 2010 at 00:21, Eelco Dolstra <e.dolstra at tudelft.nl> wrote:
> > Author: eelco
> > Date: Mon Oct 25 22:21:51 2010
> > New Revision: 24477
> > URL: https://svn.nixos.org/websvn/nix/?rev=24477&sc=1
> > 
> > Log:
> > * Fix evaluation of the luksroot module when luksRoot == null.  The
> >  problem is that configuration values below a mkIf are evaluated
> >  strictly even if the condition is false.  Thus "${luksRoot}" causes
> >  an evaluation error.  As a workaround, use the empty string instead
> >  of `null' as the default value.  However, we should really fix the
> >  laziness of mkIf.  It's likely that NixOS evaluation would be much
> >  faster if it didn't have to evaluate disabled configuration values.
> 
> I don't see how changing the condition will change the strictness of
> mkIf, so I can conclude that if this is not the issue.

It doesn't change the strictness, it simply works around this issue by making 
sure the config values can always be evaluated.

> Strictness issues can be fixed with the last property defined in
> pkgs/lib/properties.nix .

-- 
Evgeny