[Nix-dev] Re: [Nix-commits] SVN commit: nix - r24072 - nixpkgs/trunk/pkgs/development/libraries/pcre

[Lluís Batlle i Rossell]

This caused a stdenv rebuild on nixpkgs trunk.
gnugrep uses pcre.

Peter, could you make the patch so it keeps the same hash for nonDarwin?

On Tue, Oct 05, 2010 at 01:45:53PM +0000, Peter Simons wrote:
> Author: simons
> Date: Tue Oct  5 13:45:53 2010
> New Revision: 24072
> URL: https://svn.nixos.org/websvn/nix/?rev=24072&sc=1
> 
> Log:
> pkgs/development/libraries/pcre: fixed build on Darwin
> 
> The gcc version used on Darwin fails to compile the C++ interface to the PCRE
> library when optimizations are enabled. Building C++ code with -O0 remedies the
> problem. This is unsatisfactory, though, because the resulting library is
> likely to perform more poorly than it would if built with -O2 or -O3.
> 
> Modified:
>    nixpkgs/trunk/pkgs/development/libraries/pcre/default.nix
> 
> Modified: nixpkgs/trunk/pkgs/development/libraries/pcre/default.nix
> ==============================================================================
> --- nixpkgs/trunk/pkgs/development/libraries/pcre/default.nix	Tue Oct  5 13:33:48 2010	(r24071)
> +++ nixpkgs/trunk/pkgs/development/libraries/pcre/default.nix	Tue Oct  5 13:45:53 2010	(r24072)
> @@ -8,7 +8,12 @@
>      sha256 = "1zsqk352mx2zklf9bgpg9d88ckfdssbbbiyslhrycfckw8m3qpvr";
>    };
>  
> +  # The compiler on Darwin crashes with an internal error while building the
> +  # C++ interface. Disabling optimizations on that platform remedies the
> +  # problem. In case we ever update the Darwin GCC version, the exception for
> +  # that platform ought to be removed.
>    configureFlags = ''
> +    CPPFLAGS=-NDEBUG CFLAGS=-O3 CXXFLAGS=${if stdenv.isDarwin then "-O0" else "-O3"}
>      ${if unicodeSupport then "--enable-unicode-properties" else ""}
>      ${if !cplusplusSupport then "--disable-cpp" else ""}
>    '';
> _______________________________________________
> nix-commits mailing list
> nix-commits at cs.uu.nl
> http://mail.cs.uu.nl/mailman/listinfo/nix-commits