[Nix-dev] Re: git-gui: require not using ttk

[David Guibert]

Hi,

On 27/05/2010 00:02, Peter Simons wrote:
> very nice patch, thank you for your efforts!
> 
>  > +         wrapProgram --keep-name "$out/$prog"           \
>  >                       --set TK_LIBRARY "${tk}/lib/tk8.4" \
>  >                       --prefix PATH : "${tk}/bin"

As Marc suggested, I removed some duplications separating the functions
- wrapProgram
- wrapProgramKeepName

It has been tested on git and it does work,
But I don't know how to check how much will be rebuild by this patch...

> Hard-coding the Tk version number in the expression for Git doesn't feel quite
> right. Would it be possible to use pattern matching, i.e. ${tk}/lib/tk* to
> determine the path for TK_LIBRARY?

In the patch tk-libPrefix.patch, I introduce tk.libPrefix="tk8.5" and
change when it was hardcoded with the old value "tk8.4".

-- 
Regards, David
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: tk-libPrefix.patch
Url: http://lists.science.uu.nl/pipermail/nix-dev/attachments/20100527/f52cbf07/attachment.pl 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wrapProgram.patch
Url: http://lists.science.uu.nl/pipermail/nix-dev/attachments/20100527/f52cbf07/attachment-0001.pl