[Nix-dev] Re: git-gui: require not using ttk

[David Guibert]

Hi,

I'm a little too late, I see your message when I've finished testing...

On 26/05/2010 21:34, Marc Weber wrote:
> Excerpts from Yury G. Kudryashov's message of Wed May 26 20:20:05 +0200 2010:
>> Marc Weber wrote:
>>
>>> Excerpts from Yury G. Kudryashov's message of Wed May 26 19:35:22 +0200
>>> 2010:
>>>> I'd propose to change wrapProgram globally to move original program to
>>>> .orig/originalName instead of .original-name-wrapped. In this case we
>>>> shall not have such problems (progs assert that they know $0) in the
>>>> future.
>>>
>>>
>>> Which will not work for all cases because some apss might be using
>>> something like this: Calling apps relative to current bin directory:
>>>
>>> exec $(dirname $0)/other-app
>>>
>>> So you may fix git-gui but you may break others.
>>> So should an option be created eg:
>>>
>>>   wrap --keep-name # use .orig/name
>>>   wrap --keep-path # use .name-wrapped
>> OK for me
> 
> Is this all worth the effort? The git patch seems trivial to me.

See the attached patch. The two options have been introduced.
git gui and git citool are fully functional (with ttk the theme is
different than without).

[...]
> So this patch does:
> 
> - move code of wrapProgram into doWrapProgam adding the mkdir command in
>   case the hidden location is a new path. Also adding new arg receiving
>   hidden name.
> 
> - add new function wrapProgramKeeepBasename

s/Keeep/Keep/

> Should it be comitted to stdenv-updates? Does someone know how much will
> be rebuild?
> 
> Caution: I didn't test this patch yet - Just wondering whether its
> important enough to be comitted at all.
-- 
Regards, David
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wrapProgram.patch
Url: http://lists.science.uu.nl/pipermail/nix-dev/attachments/20100526/5a3633c3/attachment.pl