[Nix-dev] Re: [Nix-commits] SVN commit: nix - 22282 - MarcWeber - nixpkgs/branches/stdenv-updates/pkgs/stdenv/generic

[Ludovic Courtès]

Hi!

Marc Weber <marco-oweber at gmx.de> writes:

>> That doesn’t seem useful to me since one can add, e.g.,
>> 
>>   postConfigure = "set -x";
>> 
>> And it slightly obscures the code.
>> 
>> Revert?
>
> You noticed that
>
> - now you always see all configure flags. Previously only some were printed.

AFAICS the value of ‘configureFlags’ always appears in the build log,
but I don’t see how this relates to this commit.

> - this obscuring method makes it possible to add -j and -l flags in one
>   place rather than in multiple places.
>   How do you feel about this when also thinking about the following
>   commit?

I see this factorization benefit.  However, wouldn’t it work to use
‘makeFlags’ for ‘-j’ flags?

Thanks,
Ludo’.