[Nix-dev] Re: [Nix-commits] SVN commit: nix - 19266 - MarcWeber - in nixpkgs/trunk/pkgs: development/interpreters development/interpreters/php development/interpreters/php-xdebug development/interpreters/php_configurable top-level

[Eelco Dolstra]

Hi,

Marc Weber wrote:

>    nixpkgs/trunk/pkgs/development/interpreters/php/ini-bulider.nix

This should be "ini-builder.nix".

> +args: with args;

"args: with args;" is deprecated (see the coding conventions).  (The main reason
for "with" is to kind of simulate importing a module into scope, e.g. "with lib;".)

> +    description = "php debugger and profiler extension";

In the description, "php" should be capitalized.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/