[Nix-dev] Re: Re: [PATCH 1/2] t/scons

Evgeny Egorochkin phreedom.stdin at gmail.com
Thu Dec 23 04:07:10 CET 2010


On Wednesday 22 December 2010 23:49:30 Yury G. Kudryashov wrote:
> 7c6f434c at mail.ru wrote:
> >>My commit did start the discussion that should have happened anyway, and
> >>I clearly see us coming up with a better solution than either committing
> >>or rejecting the patch in question.
> >>
> > Well, I guess that your commit was the right thing to do given that you
> > could find no negative reaction before committing and quick review led
> > you to decide it is a useful patch...
> > 
> > The question is how we make it easier to find patches to object to.
> 
> Something like reviewboard?

They also have this useful tool: 
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/

Although for this to work really well, we need reviewboard to be sitting on 
top of a DVCS mirror, not svn.

I'll wait for more people to chime in before spending my time packaging this.

FYI ReviewBoard is used by KDE.

-- 
Evgeny



More information about the nix-dev mailing list