[Nix-dev] Re: [PATCH 1/2] t/scons

[Marc Weber]

Excerpts from Peter Simons's message of Tue Dec 21 11:59:28 +0100 2010:
> Hi Evgeny,
> 
>  > Committed.
> 
> I don't want SCons to have any fancy defaults on NixOS. I want it to behave
> exactly like it behaves in all other distributions, too. Consequently, I am
> opposed to applying this patch, and I would respectfully ask you to please
> revoke it.

Before you ask others to revoke patches (which solve issues) make clear
in your mails why you think so.

Read the documentation:

   path = ['/usr/local/bin', '/bin', '/usr/bin']
   env = Environment(ENV = {'PATH' : path})


That's the default path which means scons is useless because on nixos
there is no /usr/local/bin. This means scons is not taking into account
PATH - which makes it ignore buildInputs etc.

If you start asking for revoking such patches you also have to ask for
revoking gcc wrappers etc.

(my two cents on this)

So you should really give more details about why you think that this
patch could break something you care about.
Finding this patch took me quite a while of debugging. And If this patch
saves others from spending that time on debugging scons issues I'd be happy.
IMHO nixpkgs should serve the users - and if we can make it "do the
right thing" in more cases we should do so.

Of course this is only my humbled opinion.

Marc Weber