[Nix-dev] Re: [Nix-commits] SVN commit: nix - 21131 - MarcWeber - in nixpkgs/trunk/pkgs: development/libraries development/libraries/wvstreams development/tools/misc development/tools/misc/usb-modeswitch os-specific/linux os-specific/linux/wvdial top-level

[Eelco Dolstra]

Hi,

Marc Weber wrote:

> --- nixpkgs/trunk/pkgs/development/libraries/wvstreams/default.nix	                        (rev 0)
> +++ nixpkgs/trunk/pkgs/development/libraries/wvstreams/default.nix	2010-04-16 15:56:28 UTC (rev 21131)
> @@ -0,0 +1,23 @@
> +args: with args;

"args: with args;" is strongly discouraged.  Please list the dependencies of a
package explicitly.  See
http://hydra.nixos.org/build/352972/download/2/manual/#id387580.

It's worth noting that in the new Nix evaluator (in the fast-eval branch) "args:
with args;" is slower than "{ ... args .. }" because the former looks up an
attribute in an attribute set and the latter gets the variable from an array.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/