[Nix-dev] Re: [Nix-commits] SVN commit: nix - 20980 - eelco - nix/branches/fast-eval/src/libexpr

[Eelco Dolstra]

Hi,

Nicolas Pierron wrote:

> On Thu, Apr 8, 2010 at 13:25, Eelco Dolstra <e.dolstra at tudelft.nl> wrote:
>> Log:
>> * Fix blackholing.  If evaluation fails due to an assertion failure,
>>  then the blackhole has to be removed to ensure that repeated
>>  evaluation of the same value gives an assertion failure again rather
>>  than an "infinite recursion" error.
> 
> Why would you evaluate it again?  You want to cache the failure too.

There is no cache.

I did try marking the values on the evaluation stack as "failed" but it gave no
measurable performance improvement (on "nixpkgs -qa '*' --drv-path").

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/