[Nix-dev] Re: [Nix-commits] SVN commit: nix - 17456 - MarcWeber - in nixpkgs/trunk/pkgs/applications/version-management/git-and-tools: . git

[Ludovic Courtès]

Hi Marc,

Marc Weber <marco-oweber at gmx.de> writes:

> You can view the changes in this commit at:
>    https://svn.nixos.org/viewvc/nix?rev=17456&view=rev

[...]

> -  patches = [ ./docbook2texi.patch ];
> +  patches = [ ./docbook2texi.patch ]
> +      ++ # adds possibility to highlight all changes to files matching a glob pattern
> +          stdenv.lib.optional (guiSupport && gitkGlobSupport) (fetchurl {
> +          url = "http://mawercer.de/~marc/git-jrnieder.patch";
> +          sha256 = "187wf8chdjifwh3rrdc80nkak08jk7n74xq1bfzr2bhx2wicrv0x";
> +          });

No, please, no.  If you think the patch is useful, please submit it
*upstream*.  Releases of Git are quite frequent so you wouldn’t have to
wait for too long until it’s part of the official package.

Thanks!

Ludo’.