[Nix-dev] Re: [Nix-commits] SVN commit: nix - 17371 - eelco - nix/trunk/src/libexpr

[Michael Raskin]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Eelco Dolstra wrote:
> * tryEval shouldn't catch all exceptions of type Error, since not all
>   of them leave the evaluator in a continuable state.  Also, it should
>   be less chatty.

What are these that spoil the state?

> -    } catch (Error & e) {
> -        printMsg(lvlInfo, format("tryEval caught an error: %1%: %2%") % e.prefix() % e.msg());

> +    } catch (AssertionError & e) {
> +        printMsg(lvlDebug, format("tryEval caught an error: %1%: %2%") % e.prefix() % e.msg());


Erm, not that nice. I can list a set of other reasonable use-cases.
TypeError: some packages use stdenv.glibc, and tryEval could treat this
TypeError just like an assert. I am even not sure about Abort: some
packages may still use it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJKuoigAAoJEE6tnN0aWvw3+cEIALXaLSF0gHeqFxUuchSJwaMa
skdIkHvyOrBDZaDX2IfCy9tFXg+k2CvERqfoV1FUgPqfqUq7465Widwp/SXAjxxc
IB+1QCMvN79l1MKoYnicZXxJ/1F7ZJDnymfLSJwC47ChgbAUsaaXk3EPGp5MYZCu
qIhWSrw4mFDQOsNT4+zFXqChsNYwdncMQhRsMPfRzRKnhX6OgWnwMmXh7R7GwEIp
wxNxZyvC7X0pk72vpsnBXTEnsWfgFv6bJurc9i4jTxsRI5msOgIDbPswEmCyN+A3
CU0o0+FYr0pBKSaYNvHeprujEAvxnM0ycPks+45riX1eGunYZGgBQfJ5JMG8IKM=
=I08t
-----END PGP SIGNATURE-----