[Nix-dev] Re: [Nix-commits] SVN commit: nix - 17834 - ludo - nixpkgs/trunk/pkgs/applications/audio/snd

[Lluís Batlle]

Shouldn't be used TMPDIR, and don't attempt anything at /tmp?
And if that file is necesary for the build, you allowed the copy not to be done.
I don't know any details of this package, though.

Regards,
Lluís.

2009/10/15 Ludovic Courts <ludo at gnu.org>:
> Author: ludo
> Date: 2009-10-15 16:53:45 +0000 (Thu, 15 Oct 2009)
> New Revision: 17834
>
> You can view the changes in this commit at:
>   https://svn.nixos.org/viewvc/nix?rev=17834&view=rev
>
> Modified:
>   nixpkgs/trunk/pkgs/applications/audio/snd/default.nix
>
> Log:
> Snd: Don't expect /tmp to be writable.
>
> Changes:
>
> Modified: nixpkgs/trunk/pkgs/applications/audio/snd/default.nix
> ===================================================================
> --- nixpkgs/trunk/pkgs/applications/audio/snd/default.nix       2009-10-15 14:41:59 UTC (rev 17833)
> +++ nixpkgs/trunk/pkgs/applications/audio/snd/default.nix       2009-10-15 16:53:45 UTC (rev 17834)
> @@ -46,9 +46,10 @@
>             '' ["defEnsureDir"];
>
>   preBuild = fullDepEntry (''
> -               cp config.log /tmp/snd-config.log
> +                if [ -d /tmp ] && [ -w /tmp ]; then
> +                   cp -v config.log /tmp/snd-config.log
> +                fi
>                export NIX_LDFLAGS="$NIX_LDFLAGS -L${args.libX11}/lib -lX11"
> -
>             '') ["minInit" "doUnpack" "makeDocsWork"];
>
>   name = "Snd-" + version;
>
> _______________________________________________
> nix-commits mailing list
> nix-commits at cs.uu.nl
> http://mail.cs.uu.nl/mailman/listinfo/nix-commits
>