[Nix-dev] Re: [Nix-commits] SVN commit: nix - 17650 - MarcWeber - nixos/trunk/modules/system/upstart

[Eelco Dolstra]

Hi,

Marc Weber wrote:

> Log:
> adding jobAttrs which is filled from jobs contents
>    Purpose: Allow overwriding of properties such as:
>            config.jobAttrs.sshd.startOn = "never";
> 
> thanks to Nicolas Pierron for reviewing and
> extending nixpkgs to make this possible
> 
> I'll convert most of the jobs ASAP so please don't care
> about the depreceateion much right now

Hold on - this seems like a somewhat major change, and I'm not convinced yet
that I agree with this.  Some discussion would have been nice.

For one thing, we recently changed from services.extraJobs to jobs (a process
which isn't even finished), and now you're changing this to "jobAttrs"?

(It seems like a good idea in principle, but I don't like the name "jobAttrs".
Wouldn't sticking with "jobs" be better?)

On spelling: I think I've noticed (and fixed) the word "depreceated" half a
dozen times by now :-)  Also, please pay close attention to the text of option
descriptions, as they are visible to end users.  A line like "It's filled by
config.jobs by now. A warning is print." leaves a bad impression for several
reasons.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/