[Nix-dev] Re: Ordering of ‘checkPhase’ and ‘installPhase’

[Rob Vermaas]

Hi Ludo,

> This is Plain Wrong(TM).  The ‘check’ makefile target must *not* depend
> on the installed software (there’s ‘installcheck’ for that).  In
> particular, it’s very important for ‘check’ to test the software that’s
> just been built in $(builddir), not the one that’s installed.
>
> If Stratego’s build system relies on this bogus behavior, it should
> change the order of phases in its own ‘release.nix’.  Another option is
> for Stratego to have ‘check’ do nothing and do the actual tests in
> ‘installcheck’.

I agree with your reasoning, but as I do not have the time to change
that in the next days for the StrategoXT packages, I reverted the
patch until this has been changed. There are quite a lot of people
here at TU Delft that are dependent on these (strategoxt related)
builds, and therefore this has revert been done.

greetings,
Rob