[Nix-dev] Re: Python `setuptools' reverted to `builderDefs'

[Michael Raskin]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> The `setuptools' expression based on `stdenv' could still be called with
> `python = pythonFull' or `python = pythonBase'.  What difference does it
> make to use `builderDefs' here?

Well, you need some special-casing that way to do it without full
argument list repetition in one place or another. It is possible to do
it with stdenv style and some wrappers, but I suspect I may need a more
complicated override in future..

> "Easier to understand" probably depends on who is looking at it.  That
> `builderDefs' uses a different style and conventions than `stdenv' and
> the "core" of Nixpkgs is one thing that already makes it harder to
> understand, for me.

If you want to check that setuptools are built the right way, checking
builderDefs-generated straightforward builder script is objectively
simpler. Just because there is less code and less if's..

> If `builderDefs' has features that are a noticeable improvement over
> `stdenv', then I think we should discuss them, one-by-one, and see how
> to integrate them in (or merge them with) `stdenv'.  Having two package
> styles as different as `stdenv' and `builderDefs' just doesn't sound
> right to me.  I would prefer more homogeneity.

It is currently impossible. If we have a static builder and influence
its behavior with environment variables, we are bound to rebuild
everything once that magic script changes. That also means that direct
incorporation of features in the script is slowed down. This also puts a
limit on overrides.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQEcBAEBAgAGBQJKGx3zAAoJEE6tnN0aWvw3aR8IAKM6Em8omUR+3cUC1XonJag1
hPUEwkIz2JmGnh+RjEl2tf8Ni5Dg/EHl4t3VahB83mEn0YC2BLpVq4tYcNjc16ms
vv1z0NQtP6df2ngG8jv61KbaWHraEYbKzn9V7AWST8+spxXtbiYH6JduiilHuoGs
og5TQgShRTHfQ7+hq91BBv+/Wq3piFLt+JV/b40YehOJVLjteWxP027einEncsTj
ieVDXAcg8KBivIGxyXWT0KiarljhBksBr+WQsqXaQcPEIx8pQiZncc2vMNyTz61T
azBA20fnhypkDcTbE8UCrCm4lAl2SBdrzzyUCtdX5SW9Z8o82tuIFWVWSt01ZPY=
=+PQy
-----END PGP SIGNATURE-----