[Nix-dev] Re: [Nix-commits] SVN commit: nix - 16100 - MarcWeber - in nixpkgs/trunk/pkgs: applications/editors/eclipse applications/graphics/cinepaint applications/graphics/gimp/plugins build-support/buildenv development/interpreters/ruby top-level

[Ludovic Courtès]

Hello,

Marc Weber <marco-oweber at gmx.de> writes:

> --- nixpkgs/trunk/pkgs/development/interpreters/ruby/libs.nix	                        (rev 0)
> +++ nixpkgs/trunk/pkgs/development/interpreters/ruby/libs.nix	2009-06-30 14:29:20 UTC (rev 16100)

Why not follow the file name and location, style, and conventions of
`perl-packages.nix' (and `python-packages.nix', which is based on it)?
See `doc/language-support.xml'.

> +    rubyDerivation = args :

[...]

> +          )); in stdenv.mkDerivation (removeAttrs completeArgs ["mergeAttrBy"]);

Why not prefix names with `ruby-' (by default) as is done for Perl and
Python?  See below...

> +    rubygems_update_1_3_4 = rubyDerivation {

Why not comply with the coding style of Nix*, i.e., camelCase instead of
under_scores?

> +    ncurses_0_9_1 = rubyDerivation {
> +       name = "ncurses-0.9.1"; # full_name

[...]

> +    gettext_2_0_4 = rubyDerivation {
> +       name = "gettext-2.0.4"; # full_name

These, and possibly others, will have disastrous effects when running
`nix-env -u \*' for anyone who has ncurses or GNU Gettext installed.

Please, prefix *all* these package names with `ruby-', unless you are
100% sure that they don't collide with any non-Ruby package whatsoever.
(I manually prefixed `ruby-gettext' in r16120 and then stumbled upon
`ncurses'; it's safer to prefix all the package names.)

Thanks,
Ludo'.