[Nix-dev] Re: [Nix-commits] SVN commit: nix - 16100 - MarcWeber - in nixpkgs/trunk/pkgs: applications/editors/eclipse applications/graphics/cinepaint applications/graphics/gimp/plugins build-support/buildenv development/interpreters/ruby top-level

[Eelco Dolstra]

Hi,

Marc Weber wrote:

Some comments:

> --- nixpkgs/trunk/pkgs/build-support/buildenv/builder.pl	2009-06-30 14:29:17 UTC (rev 16099)
> +++ nixpkgs/trunk/pkgs/build-support/buildenv/builder.pl	2009-06-30 14:29:20 UTC (rev 16100)
> @@ -21,7 +21,9 @@
>      my $path = shift;
>      $path = "/" if $path eq "";
>      foreach my $elem (@pathsToLink) {
> +        print "isInPathsToLink elem, path $elem , $path\n";
>          return 1 if substr($path, 0, length($elem)) eq $elem;
> +        print "no\n";

Was it your intent to commit all these debug statements in buildenv/builder.pl?

> +  # TODO don't resolve 302 redirects but make nix resolve in fetchurl and
> +  # nix-prefetch-url. This should be done on stdenv-updates.

Changes to fetchurl are harmless so they can also be done on the trunk.

> +  # ================ START automatically generated code ================

Isn't it better to have the generated code in a separate file?

> +
> +           # WARNING: automatically generated CODE
> +           # This section has been generated by gem nix sup rubygems-update
> +           # the gem nix command has been added by a nix patch to ruby gems
> +        
> +    rubygems_update_1_3_4 = rubyDerivation {
> +       name = "rubygems-update-1.3.4"; # full_name
> +       nameNoVersion = "rubygems-update";

Why not have a "name" attribute (without the version) and a "version" attribute?

> +         description = "RubyGems is a package management framework for Ruby.
> +
> +  This gem is an update for the RubyGems software.  You must have an
> +  "; # cut to 120 chars

meta.description should not contain newlines since it screws up nix-env -q output.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/