[Nix-dev] Re: [Nix-commits] SVN commit: nix - 16460 - eelco - in nixos/branches/modular-nixos/modules/services/networking: . ssh

[Nicolas Pierron]

On Sun, Jul 26, 2009 at 23:24, Eelco Dolstra<e.dolstra at tudelft.nl> wrote:
> Eelco Dolstra wrote:
>
>> Nicolas Pierron wrote:
>>
>>>> +    # !!! This barfs because of the mkIf ("value is a list while an
>>>> +    #attribute set was expected") :-(
>>>> +    #networking.firewall.allowedTCPPorts = [22];
>>>> +
>>>>   };
>>>>
>>>>  }
>>> This is working if you don't forget to import "firewall.nix".  Didn't
>>> I mention that maintaining such things by hand sucks?
>>
>> I do import it in my own configuration.nix.
>
> But I forgot that the generation of the configuration.nix manpage uses an empty
> configuration that didn't include firewall.nix.  Doh.
>
> However I don't agree that this has anything to do with maintaining the default
> import list by hand.  I didn't include firewall.nix yet because it wasn't ready,
> and no automatic tool can determine whether such a module should be included.

This is the reason why I've suggested to put this information inside
modules.  This can be retrieved by a tool which generates the proper
lists.

-- 
Nicolas Pierron
http://www.linkedin.com/in/nicolasbpierron
A borderless war is along the way! Do you copy?