[Nix-dev] Re: [Nix-commits] SVN commit: nix - 16341 - viric - in nixpkgs/trunk/pkgs: tools/misc/grub top-level

[Michael Raskin]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Llus Batlle wrot> Adding a patch for grub, so livecds with grub can
still boot with buggy bioses,
> as those of Acer 292LMi or Airis N990. This allows booting the NixOS ISO releases.
> I made it optional, not included by default. I don't think it would harm at all enabling
> it always - let it be decided on forum.

> +   grub_memset (&cdrp, 0, sizeof (cdrp));
> +   cdrp.size = sizeof (cdrp) - sizeof (cdrp.dummy);
> +   err = biosdisk_int13_extensions (0x4B01, drive, &cdrp);
> ++  err = 0; /* really ugly hack to circumvent faulty BIOS versions like Acer 292LMi */
> +   if (! err && cdrp.drive_no == drive)
> +     {
> +        if ((cdrp.media_type & 0x0F) == 0)

I vote for on-by-default and the flag would allow to remove the patch.

Someone could want to get failure earlier if one of a few tested
machines changes its behavior, but by default it doesn't seem to affect
correctly working BIOS..
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQEcBAEBAgAGBQJKW5UMAAoJEE6tnN0aWvw3y2IIAIy0cBlHs8IMrQJtf4hUy2Pz
aZyPmHzzOwEtCiH8YKA36I0C/q3UJmCcC7h6FxJw8piK6pzJeZxx4uctKmH1UlZq
UqwMUssAPqTcBgxrrmXZ+tJITHfYhCEKNPnInZIR/0uC5P7hRhpT4VGeUYwMQ+5X
+VmPI1JPq89xtZ+6o4TCCJidFgs/5xb8SVoVrb8n7t5WEZf2r/U2fVZeBUcopGpx
0aPYyMAtj6T9Ds1xlh6uRyZmmE4a0t3wyr9t09hMbNmwJ2qm6iMJcjSlpt8rS6v7
+iCyvBwCHXFowdO319YuiPKDnFUGAsw2ENFweV6SywIQyp/ShrmzWVTcF1/Ubp8=
=HrGV
-----END PGP SIGNATURE-----