[Nix-dev] Re: Enlightenment-0.16 patches

[Ludovic Courtès]

Hello, and welcome on board!  ;-)

"John Altobelli" <acocaracha at gmail.com>
writes:

> --- nixpkgs/pkgs/desktops/enlightenment/default.nix	2009-01-19 18:37:11.000000000 -0500
> +++ /dev/null	2009-01-19 18:43:59.148001034 -0500
> @@ -1,12 +0,0 @@
> -{ stdenv, fetchurl, pkgconfig, x11, xlibs, dbus, imlib2, freetype }:

Your patch is reversed (it should be pluses, not minuses), but that's a detail.

> -let version = "0.16.8.15"; in
> -stdenv.mkDerivation (rec {
> -  name = "enlightenment-${version}";

You don't need `rec' (the recursive attribute set constructor) here.  Or
you could discard `version' and write:

  rec {
    name = "enlightenment-0.16...";
    url = "mirror://.../${name}.tar.gz";
  }

The expression also lacks a `meta' attribute, which is quite helpful.

Other than that, the patch looks good to me!

Thanks,
Ludo'.