[Nix-dev] Re: [Nix-commits] SVN commit: nix - 18990 - eelco - nixos/trunk/modules/config

[Ludovic Courtès]

Hello,

Eelco Dolstra <e.dolstra at tudelft.nl> writes:

> You can view the changes in this commit at:
>    https://svn.nixos.org/viewvc/nix?rev=18990&view=rev

[...]

> Log:
> * Revert r18985, but now handle the case where a nixbld user doesn't
>   exist yet.  Ludo's original patch only worked in the "update" case.
>   Also, do this only for the nixbld group.

Indeed, thanks for fixing it!

> --- nixos/trunk/modules/config/users-groups.nix	2009-12-16 11:06:28 UTC (rev 18989)
> +++ nixos/trunk/modules/config/users-groups.nix	2009-12-16 13:35:03 UTC (rev 18990)
> @@ -32,8 +32,8 @@
>               calls in `libstore/build.cc', don't add any supplementary group
>               here.  */
>            uid = builtins.add ids.uids.nixbld nr;
> -          group = "nogroup";
> -          extraGroups = ["nixbld"];
> +          group = "nixbld";
> +          extraGroups = [];
>          };

So this had been changed without updating the comment that says “don’t
add any supplementary group”?  That’s unpleasant.

BTW, could you update NixOS on Hydra and restart it?  I’d like to make
sure the change makes the Coreutils test suite happier.

Thanks,
Ludo’.