[Nix-dev] Re: [Nix-commits] SVN commit: nix - 18986 - MarcWeber - nixos/trunk/tests/test-nixos-install-from-cd

[Eelco Dolstra]

Hi,

Marc Weber wrote:

> Author: MarcWeber
> Date: 2009-12-16 04:55:35 +0000 (Wed, 16 Dec 2009)
> New Revision: 18986
> 
> You can view the changes in this commit at:
>    https://svn.nixos.org/viewvc/nix?rev=18986&view=rev
> 
> Modified:
>    nixos/trunk/tests/test-nixos-install-from-cd/test.nix
> 
> Log:
> cleaned up kvm installation test. It works now.

Having a test for the installer is great (and on my todo list for a while), but
is there a reason why you're reinventing the testing framework in
lib/test-driver?  For sure there are many things that can be improved there, but
it seems better to have some consistency between the NixOS regression tests.

-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/